chore: separate dev dependencies from prod dependencies for pip#57
chore: separate dev dependencies from prod dependencies for pip#57AlexButeau wants to merge 2 commits intomainfrom
Conversation
WalkthroughThe pull request updates the development dependency setup. The installation command in the documentation has been changed to point to a dedicated development requirements file. A new file for development dependencies has been added, which builds on production dependencies and includes additional tools for testing and code formatting. The project’s setup configuration has been adjusted to remove testing packages from the core installation and to offer them as an optional extras group. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| 2. Install dependencies | ||
| ```bash | ||
| pip install -r requirements.txt | ||
| pip install -r requirements_dev.txt |
There was a problem hiding this comment.
I haven't used pip install -e .'[dev]' in test-current-version.yml because from what I understand, pytest is not necessary in those tests and I wanted to stay as close as possible to "real" conditions, where the client installs tofupilot without the dev dependencies.
However it only works because we wanted to disable the pytest plugin for now. If we want to include it again, we'll have to change the dependencies VS dev dependencies.
|
Also linked to issue #55 SDK-55 |
|
Probably outdated, feel free to reopen if not |
Summary by CodeRabbit