Skip to content

chore: separate dev dependencies from prod dependencies for pip #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexButeau wants to merge 2 commits into from
Closed

chore: separate dev dependencies from prod dependencies for pip #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26c6eb8
chore: separate dev dependencies from prod dependencies for pip
AlexButeau Mar 10, 2025
5e72799
chore: remove pytest plugin import and def
AlexButeau Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ To set up a local development environment:
```
2. Install dependencies
```bash
pip install -r requirements.txt
pip install -r requirements_dev.txt
Copy link
Copy Markdown
Contributor Author

@AlexButeau AlexButeau Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used pip install -e .'[dev]' in test-current-version.yml because from what I understand, pytest is not necessary in those tests and I wanted to stay as close as possible to "real" conditions, where the client installs tofupilot without the dev dependencies.
However it only works because we wanted to disable the pytest plugin for now. If we want to include it again, we'll have to change the dependencies VS dev dependencies.

```

## Style Guide
Expand Down
3 changes: 3 additions & 0 deletions requirements_dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-r requirements.txt # Include production deps
pytest
black
9 changes: 5 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
name="tofupilot",
version="1.9.4",
packages=find_packages(),
install_requires=["requests", "setuptools", "packaging", "pytest", "websockets"],
entry_points={
"pytest11": [
"tofupilot = tofupilot.plugin", # Registering the pytest plugin
install_requires=["requests", "setuptools", "packaging", "websockets"],
extras_require={
"dev": [
"pytest",
"black",
],
},
author="Félix Berthier",
Expand Down
1 change: 0 additions & 1 deletion tofupilot/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@
"""

from .client import TofuPilotClient
from .plugin import numeric_step, string_step, conf
from .models import MeasurementOutcome, PhaseOutcome