Skip to content

herodot:1.0.0#4181

Merged
elegaanz merged 2 commits intotypst:mainfrom
gnist-dev:herodot-1.0.0
Mar 4, 2026
Merged

herodot:1.0.0#4181
elegaanz merged 2 commits intotypst:mainfrom
gnist-dev:herodot-1.0.0

Conversation

@gnist-dev
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Description:

Added the following fields for customizing the timeline:

  • event.offset field for setting the length of an event's vertical line mark
  • logic for taking into account whether an event is above or below the timeline, and how that should affect it being displayed
  • replaced the timeline.spanheight field for eventspan.spanheight field, so that it can be set on a per time-span basis (breaking backwards compatibility)

also:

  • bumped cetz from 0.4.1 to 0.4.2

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small remarks to improve your README. The second is really more of a suggestion. We didn't really have these rules/tips in our package review process previously, which is why I didn't suggest them for the previous versions.

Comment on lines +23 to +27
@@ -24,6 +24,7 @@ fields and options the package has.
![image](examples/example-2.png)
![image](examples/example-3.png)
![image](examples/example-4.png)
![image](examples/example-5.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual image descriptions would be appreciated here. They don't have to go into much detail, but should convey the main idea behind the image to people relying on screen readers (or for whom the image couldn't properly load, for example if they have poor internet connectivity). You can imagine that you are reading the README to someone on the phone, and you have to describe what the images show with words, this generally helps to come up with a good alternative text.

@@ -1,4 +1,4 @@
#import "lib.typ": *
#import "@local/herodot:1.0.0": *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to link to this file in the README too, so that users can use this file as a sort of reference: they can scroll through the PDF to find a timeline configured the way they want, and then navigate to the corresponding section of the source to copy it.

If you do so, updating this import to @preview would be better, as it would allow people to just copy/paste the file to get started, and get a valid result without further modification.

    - added link to examples.typ in the readme
    - added image descriptions
@elegaanz
Copy link
Member

elegaanz commented Mar 4, 2026

Great, thank you!

@elegaanz elegaanz merged commit a42ee80 into typst:main Mar 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update A package update.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants