-
Notifications
You must be signed in to change notification settings - Fork 2
Test Script for Vision Stack #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WithanagePerera
wants to merge
13
commits into
main
Choose a base branch
from
Praveen-VisionStackTests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_cam topic has a specific message type.
… from the front_cam topic because it's not in a correct format. Currently trying to figure out how to convert it to a numpy array.
…nCV image. Also found more issues with the VisionStack application class, specifically the publisher naming conventions which cause the publisher initialization to fail. Got it working, but will have to make some more robust fixes.
…nCV image. Also found more issues with the VisionStack application class, specifically the publisher naming conventions which cause the publisher initialization to fail. Got it working, but will have to make some more robust fixes.
…th the example construction of ObjectDetectionLayer.
…etectionLayer since it uses weights, but the subscriber isn't running for some reason even though simulation is going.
…us which publisher corresponds to which filter.
…or me. Also cleaned up the vision_stack_test code and check that all layers work and I'm able to visualize them.
DaniParr
requested changes
Nov 4, 2025
… I made to some of the layer scripts. I agree with Daniel that changes to something as important as layers deserve their own PR.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted my team (VisualLocalization) to have an application class they can use to test the Vision Stack code with, as well as test code for layers they may implement.
To do so, I create a script called
vision_stack_test.pylocated in thetestdirectory. It creates a subscriber to thefront_cam/image_rawtopic and feeds that data to a VisionStack object. I've initialized every layer possible with the exception ofRobustScalingandSobelbecause they return floating point values which are unsupported? (I was getting an error because of their fp encoding type, I'll take a look in the future).This PR also has some changes to the VisionStack.py class to counteract some issues I had with imports and passing image data. The original implementation also had an issue with the naming of layer topics, so I changed the naming such that the topic for each CV layer uses the same name as the Python layer class.
For example, the topic for the Grayscale layer is called
front_cam/GrayscaleLayer.