Skip to content

Conversation

@jurgenvinju
Copy link
Member

@jurgenvinju jurgenvinju commented Nov 26, 2025

This could have let to very subtle bugs. Chain rules are important for the type system, and they can't be removed. The reason is that chain-rules do not lead to sub-types or substitutability of a tree with/without the chain node. So removing a chain application will break the type system.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47%. Comparing base (5046bef) to head (d7df43c).

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2535   +/-   ##
=======================================
  Coverage       47%     47%           
- Complexity    6705    6706    +1     
=======================================
  Files          791     791           
  Lines        65239   65239           
  Branches      9769    9769           
=======================================
+ Hits         30916   30919    +3     
+ Misses       31909   31905    -4     
- Partials      2414    2415    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jurgenvinju
Copy link
Member Author

a test failed earlier for a random case. I restarted the run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant