Skip to content

remove chain rule removal from constructor generator for syntax rules #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove chain rule removal from constructor generator for syntax rules #2535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b72167
remove chain rule removal from constructor generator for syntax rules
jurgenvinju Nov 26, 2025
d7df43c
Merge branch 'main' into remove-remove-chain-rule
jurgenvinju Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/org/rascalmpl/compiler/lang/rascalcore/check/CollectSyntaxDeclaration.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@ private bool isTerminalSym((Sym) `(<Sym symbol1> <Sym symbol2>)`) = isTerminalSy
private bool isTerminalSym((Sym) `()`) = true;
private default bool isTerminalSym(Sym s) = s is characterClass || s is literal || s is caseInsensitiveLiteral;

private AType removeChainRule(aprod(prod(AType adt1,[AType adt2]))) = adt2 when isNonTerminalAType(adt2);
private default AType removeChainRule(AType t) = t;

void collect(current: (Prod) `<ProdModifier* modifiers> <Name name> : <Sym* syms>`, Collector c){
symbols = [sym | sym <- syms, !(sym is empty)];

Expand Down Expand Up @@ -192,7 +189,7 @@ void collect(current: (Prod) `<ProdModifier* modifiers> <Name name> : <Sym* syms
!isTerminalSym(sym),
tsym := s.getType(sym),
isNonTerminalAType(tsym),
stp := getSyntaxType(removeChainRule(tsym), s)
stp := getSyntaxType(tsym, s)
];

def = \start(sdef) := def ? sdef : def;
Expand Down