Allow int values as input to drive and sequence params, remove an unused cv2 dependency#47
Open
valgur wants to merge 2 commits intoutiasSTARS:masterfrom
Open
Allow int values as input to drive and sequence params, remove an unused cv2 dependency#47valgur wants to merge 2 commits intoutiasSTARS:masterfrom
valgur wants to merge 2 commits intoutiasSTARS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes initializing the classes a bit more convenient.
The
cv2dependency is quite heavy-weight and entirely unused right now.By the way, would it be possible to create a new minor release of pykitti that incorporates the fix from #39, please? I'm using pykitti via kitti2bag and ROS1 is stuck with Python 2 for at least another year, unfortunately.