🌱 Set the VC created at timestamp in VM CR status #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisalabujabal
force-pushed
the
feat/set-vc-created-at
branch
from
c87af77 to
92b41d0
Compare
github-actions
bot
added
size/M
bryanv
reviewed
Dec 30, 2025
controllers/virtualmachine/virtualmachine/virtualmachine_controller_intg_test.go
Outdated
Show resolved
Hide resolved
| vmCtx.VM.Status.InstanceUUID = vmCtx.MoVM.Summary.Config.InstanceUuid | ||
|
|
||
| // Only set CreatedAt if it hasn't been set yet and config.createDate is available. | ||
| // This field is immutable once set. |
Contributor
There was a problem hiding this comment.
What about for restored VMs?
Contributor
Author
There was a problem hiding this comment.
what do you mean specifically? the timestamp would still backfill from the config
faisalabujabal
force-pushed
the
feat/set-vc-created-at
branch
from
92b41d0 to
00e7875
Compare
github-actions
bot
added
size/L
faisalabujabal
force-pushed
the
feat/set-vc-created-at
branch
2 times, most recently
from
edda263 to
c7c08c4
Compare
Introduing a new Provider and Provider.CreationTimestamp field in the VM's status custom resource which sets the creation timestamp from VC/VPXD on VM's creation
faisalabujabal
force-pushed
the
feat/set-vc-created-at
branch
from
c7c08c4 to
0612e83
Compare
Minimum allowed line rate is |
akutz
reviewed
Jan 26, 2026
|
|
||
| // Provider describes the observed state of the VirtualMachine from | ||
| // the underlying infrastructure provider (vSphere/vCenter). | ||
| Provider *VirtualMachineProviderStatus `json:"provider,omitempty"` |
Collaborator
There was a problem hiding this comment.
I initially loved this approach, but the more I think about it, the more it is confusing. Nearly everything in status comes from the provider, so I'm not sure we need to nest this. I'm also not convinced this should not be a condition if the goal is to understand the lifecycle of the VM since all other timestamps are part of conditions.
Contributor
Author
There was a problem hiding this comment.
my thought process for why this wouldn't fit in the conditions:
- the timestamp in the conditions represents when did the transition occur which I think will be confusing if for the case of an imported VM a condition timestamp is going to be older than the CR's creation timestamp itself.
- the condition will always transition either none or exactly once.
- I thought it was already a pattern to store such info in the status like
status.LastRestartTime
I agree that most of the CR is an abstraction of the underlying provider so I am open to other names or not having it nested.
akutz
requested changes
Jan 26, 2026
Collaborator
akutz
left a comment
akutz
left a comment
There was a problem hiding this comment.
Please consider removing the provider status type as I think it is a little weird, even though I initially loved it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Introducing a new Provider object under status to keep track of info from VC. Defined Provider.CreationTimestamp field that gets set to config.createDate on successful VM creation.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # NA
Are there any special notes for your reviewer:
What do you think of the field names and structure ?
Please add a release note if necessary: