-
Notifications
You must be signed in to change notification settings - Fork 62
🌱 Set the VC created at timestamp in VM CR status #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially loved this approach, but the more I think about it, the more it is confusing. Nearly everything in status comes from the provider, so I'm not sure we need to nest this. I'm also not convinced this should not be a condition if the goal is to understand the lifecycle of the VM since all other timestamps are part of conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my thought process for why this wouldn't fit in the conditions:
status.LastRestartTimeI agree that most of the CR is an abstraction of the underlying provider so I am open to other names or not having it nested.