Mistweaver implementation #380

Patrick-Hogeveen · 2025-06-30T16:44:32Z

First draft code for a number of mistweaver abilities and passives

Patrick-Hogeveen · 2025-07-03T20:29:28Z

sim/monk/mistweaver/soothing_mist.go

+		ClassMask:  monk.MonkSpellSurgingMist,
+	})
+
+	surgingMistChannelMod := mw.AddDynamicMod(core.SpellModConfig{


Soothing mist currently enables and disables two aura's to allow surging mist and enveloping mist to be cast while channeling (also another two aura's to reduce both spells cast time to zero). I am unsure if this is the ideal solution or if there is a better way to make this happen?

You can combine these into one pair of mods:

mistCastTimeMod := mw.AddDynamicMod(core.SpellModConfig{ Kind: core.SpellMod_CastTime_Pct, FloatValue: -1, ClassMask: monk.MonkSpellSurgingMist | monk.MonkSpellEnvelopingMist, }) mistChannelMod := mw.AddDynamicMod(core.SpellModConfig{ Kind: core.SpellMod_AllowCastWhileChanneling, ClassMask: monk.MonkSpellSurgingMist | monk.MonkSpellEnvelopingMist, })

NerdEgghead

Also make sure to add a unit test configuration for the spec.

NerdEgghead · 2025-07-04T01:37:38Z

sim/core/apl.go


-	if apl.unit.ChanneledDot != nil {
+	//Probably not the best solution, added so apl evaluates if a spell can be cast while channeling during runtime rather than on reset
+	apl.allowCastWhileChanneling = slices.ContainsFunc(apl.unit.Spellbook, func(spell *Spell) bool {
+		return spell.Flags.Matches(SpellFlagCastWhileChanneling)
+	})
+
+	if apl.unit.ChanneledDot != nil && !apl.allowCastWhileChanneling {
 		return
 	}


I think there's a simpler solution for this: you can permanently add SpellFlagCastWhileChanneling to Soothing Mist, then all you have to check is

if (apl.unit.ChanneledDot != nil) && !apl.unit.ChanneledDot.Spell.Matches(SpellFlagCastWhileChanneling) { return }

NerdEgghead · 2025-07-04T01:38:38Z

sim/core/apl.go

+	//Checking for cast-while-channeling spells to allow the APL to not evaluate during channels unless absolutely necessary
+	allowCastWhileChanneling bool


This field could be removed if you go with my previous suggestion.

NerdEgghead · 2025-07-04T01:48:41Z

sim/core/spell.go


 	// While casting or channeling, no other action is possible
-	if spell.Unit.Hardcast.Expires > sim.CurrentTime {
+	if (spell.Unit.Hardcast.Expires > sim.CurrentTime || spell.Unit.IsChanneling(sim)) && !spell.Flags.Matches(SpellFlagCastWhileChanneling) {


You should add the same correction to the CanQueue() method within sim/core/spell_queueing.go.

NerdEgghead · 2025-07-04T01:51:18Z

sim/core/unit.go

+func (unit *Unit) IsChanneling(sim *Simulation) bool {
+	return unit.ChanneledDot != nil
+}


The sim argument here is unused and can be omitted.

NerdEgghead · 2025-07-04T01:53:50Z

sim/monk/jab.go

-			BaseCostPercent: core.TernaryFloat64(monk.StanceMatches(WiseSerpent), 8, 0),
+			//This is wrong? But works?
+			BaseCostPercent: core.TernaryFloat64(monk.StanceMatches(WiseSerpent), 0, 8),


Reminder to figure out what the underlying bug is here and fix it

I'm a bit confused myself, the intention behind the original I assume was to have the mana cost be set if the player is in wise serpent stance. However when running the sim the mana cost of jab was zero. Replacing it with the above now had it properly costing mana or simply replacing it with the mana cost sans TernaryFloat64 also works and doesn't seem to disrupt the other monk sims from what I can tell.

I would leave in the costs, and then if needed based on the active Stance aura enable/disable a SpellMod that reduces the costs

NerdEgghead · 2025-07-04T02:33:59Z

sim/monk/mistweaver/soothing_mist.go

+				if envelopingActive {
+					multiplier += +0.3
+				}


Are you sure this shouldn't be multiplier *= 1.3?

NerdEgghead · 2025-07-04T02:39:34Z

sim/monk/mistweaver/soothing_mist.go

+				outcome := sim.Roll(1, 10)
+				if outcome > 7 {
+					mw.AddChi(sim, soothingMist, 1, chiMetrics)
+				}


This will simulate a 33.33% proc chance rather than a 30% proc chance. You can fix it and also simplify the code by calling

if sim.Proc(0.3, "Soothing Mist Chi") { mw.AddChi(sim, dot.Spell, 1, chiMetrics) }

Note that using dot.Spell here also eliminates the need for the dangling soothingMist pointer.

sim/monk/mistweaver/soothing_mist.go

NerdEgghead · 2025-07-04T02:45:36Z

sim/monk/mistweaver/surging_mist.go

+			baseHealing := 19630 + spellCoeff*spell.HealingPower(target)
+			//Hardcoded to heal the player for now
+			spell.CalcAndDealHealing(sim, &mw.Unit, baseHealing, spell.OutcomeHealingCrit)


If you set the BonusCoefficient field on the SpellConfig to 1.8, then you can simplify this to just

spell.CalcAndDealHealing(sim, target, 19630, spell.OutcomeHealingCrit)

and the Spell Power contribution will be handled automatically.

NerdEgghead · 2025-07-04T02:49:16Z

sim/monk/mistweaver/uplift.go

+					baseHealing := 0 + spellCoeff*spell.HealingPower(target)
+					spell.CalcAndDealHealing(sim, player, baseHealing, spell.OutcomeHealingCrit)


Same here - if you set the BonusCoefficient field to 0.68, then you can just call

spell.CalcAndDealHealing(sim, player, 0, spell.OutcomeHealingCrit)

NerdEgghead · 2025-07-12T22:15:34Z

@Patrick-Hogeveen Can you merge master into this branch and resolve any conflicts so I can re-review? We separately PR'd the casting while channeling changes in #430 .

Patrick-Hogeveen · 2025-07-14T21:39:48Z

@Patrick-Hogeveen Can you merge master into this branch and resolve any conflicts so I can re-review? We separately PR'd the casting while channeling changes in #430 .

I have synced my fork with master and resolved all conflicts. I assumed that simply accepting the incoming changes resulting from the new casting while channelling changes was the correct thing to do.

NerdEgghead

Also make sure to add a unit test configuration for the spec so that the spells you added will be tested.

NerdEgghead · 2025-07-15T17:43:28Z

sim/core/apl.go

+	//rot.allowCastWhileChanneling = slices.ContainsFunc(rot.unit.Spellbook, func(spell *Spell) bool {
+	//	return spell.Flags.Matches(SpellFlagCastWhileChanneling)
+	//})


General comment: delete any unused commented code like this for cleanliness once you are done debugging.

NerdEgghead · 2025-07-15T17:46:00Z

sim/monk/mistweaver/enveloping_mist.go

+		ProcMask:       core.ProcMaskSpellHealing,
+		Flags:          core.SpellFlagHelpful | core.SpellFlagAPL, // | core.SpellFlagCastWhileChanneling,


Did you intend to comment out the extra flag here?

NerdEgghead · 2025-07-15T17:46:46Z

sim/monk/mistweaver/enveloping_mist.go

+
+		ManaCost: core.ManaCostOptions{BaseCostPercent: 0},


You can just omit this field if the cost is 0.

NerdEgghead · 2025-07-15T17:48:13Z

sim/monk/mistweaver/enveloping_mist.go

+		//ClassSpellMask: monk.MonkSpellEnvelopingMist,
+


Did you intend to comment out the spell mask here?

NerdEgghead · 2025-07-15T17:52:36Z

sim/monk/mistweaver/enveloping_mist.go

+			if target.Type == core.EnemyUnit {
+				fmt.Printf("Attemping to cast Enveloping mist on enemy: %v\n", target.Label)
+				return
+			}


I think it would be better to panic here rather than printing a message and returning. Forcing a crash is more likely to alert the user that their APL was set up incorrectly.

NerdEgghead · 2025-07-15T18:18:33Z

sim/monk/mistweaver/soothing_mist.go

+				if envelopingActive {
+					dot.SnapshotAttackerMultiplier = 1.3
+				} else {
+					dot.SnapshotAttackerMultiplier = 1
+				}


Should these be *= rather than =? Otherwise you lose the original result of the CasterHealingMultiplier() call.

I'm not sure? The way it is now is currently working. Changing it to *= causes the healing to increase each time it ticks while enveloping mist is active where it should be a 30% increase in healing while enveloping mist is active and normal when it is not. Perhaps an aura would work better than my current implementation?

What you could (and most of us) do is:

multiplier := core.TernaryFloat(mw.envelopingMist.RelatedDotSpell.Hot(target).IsActive(), 1.3, 1.0) dot.SnapshotAttackerMultiplier *= multiplier dot.CalcAndDealPeriodicSnapshotHealing(sim, target, dot.OutcomeTick) dot.SnapshotAttackerMultiplier /= multiplier

Basically adding > casting > removing the multiplier to not get infinite 30% gain.

NerdEgghead · 2025-07-15T18:20:47Z

sim/monk/mistweaver/soothing_mist.go

+		ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
+			//Currently target mistweaver only, will need to fix this


This comment is no longer accurate.

NerdEgghead · 2025-07-15T18:21:46Z

sim/monk/mistweaver/soothing_mist.go

+			if target.Type == core.EnemyUnit {
+				fmt.Printf("Attemping to cast Enveloping mist on enemy: %v\n", target.Label)
+				return
+			}


Same comment, panic here so you fail loudly rather than silently.

NerdEgghead · 2025-07-15T18:24:36Z

sim/monk/mistweaver/surging_mist.go

+			chiGain := int32(1)
+			mw.AddChi(sim, spell, chiGain, chiMetrics)


You don't need to define a new variable for single-use parameters like this, you can just call

mw.AddChi(sim, spell, 1, chiMetrics)

NerdEgghead · 2025-07-15T18:28:24Z

sim/monk/tiger_palm.go

+					if monk.MuscleMemoryAura.IsActive() {
+						result.Damage += result.Damage * 1.5


You can just do

result.Damage *= 2.5

1337LutZ · 2025-07-18T06:52:47Z

sim/monk/mistweaver/uplift.go

+				if hot.IsActive() {
+
+					spell.CalcAndDealHealing(sim, player, 0, spell.OutcomeHealingCrit)
+					success = true


Can heals on a target ever fail? or does this spell in-game not cost Chi if you had 0 targets healed?
otherwise this spell should always just SpendChi

I believe that you can not cast it at all if there's no renewing mist active

1337LutZ · 2025-08-11T18:31:44Z

sim/monk/blackout_kick.go

 				}
+
+				if monk.MuscleMemoryAura.IsActive() {
+					result.Damage += result.Damage * 1.5


This should probably become a 0.5 DamageDonePct SpellMod on the Aura itself, because right now you are actually not going a 150% mod, but 250%. (100% of the original result + 150% of the original result * 1.5)

1337LutZ · 2025-08-11T18:32:27Z

sim/monk/mistweaver/mana_tea.go

+	manaPerTick := 0.0
+	//numerOFTicks := 6
+
+	mw.Monk.RegisterOnChiSpent(func(sim *core.Simulation, chiSpent int32) {


mw.RegisterOnChiSpent should work

1337LutZ · 2025-08-11T18:32:32Z

sim/monk/mistweaver/mana_tea.go

+		MaxStacks: 20,
+	})
+
+	mw.Monk.RegisterOnNewBrewStacks(func(sim *core.Simulation, stacksToAdd int32) {


mw.RegisterOnNewBrewStacks should work

1337LutZ · 2025-08-11T18:34:06Z

sim/monk/mistweaver/passives.go

+
+			dmgDone = result.Damage
+			//Should be a smart heal
+			serpentZealHeal.Cast(sim, &mw.Unit)


Does it need to be smart here? Or in the ApplyEffects part of this heal? There you can loop over all friendlies and find the lowest HP Unit

It definitely could be done in ApplyEffects, I just left that there as a reminder to myself since I wasn't sure if the raid member target dummies technically had health pools so I hadn't thought up how to implement it as a smart heal yet.

1337LutZ · 2025-08-11T18:34:37Z

sim/monk/mistweaver/passives.go

+			}
+			aura.Deactivate(sim)
+		},
+	})


Here you should add the 1.5 .AttachSpellMod for the 2 BCK and TP

1337LutZ · 2025-08-11T18:35:44Z

sim/monk/mistweaver/renewing_mist.go

+	chiMetrics := mw.NewChiMetrics(actionID)
+	spellCoeff := 0.19665 //Will have to verify this
+	//targets := mw.Env.Raid.GetFirstNPlayersOrPets(int32(mw.Env.Raid.NumTargetDummies))
+	charges := 3


Probably better to keep this in a "Dummy Aura" that has stacks. Then the timeline will show how many charges the Aura had.

1337LutZ · 2025-08-11T18:36:30Z

sim/monk/mistweaver/renewing_mist.go

+
+		Hot: core.DotConfig{
+			Aura: core.Aura{
+				Label: "Renewing Mist",


I think you can actually add MaxStacks here and use this Aura for the "charges"

1337LutZ · 2025-08-11T18:59:51Z

sim/monk/tiger_palm.go

 					}
+
+					if monk.MuscleMemoryAura.IsActive() {
+						result.Damage += result.Damage * 1.5


Would be nice to also move this to a 0.5 SpellMod, same as BCK. And it's not 250% but 150%, so add 50% of the original damage

Patrick-Hogeveen and others added 29 commits May 13, 2025 17:53

Added mistweaver to alpha

b181ff2

Merge branch 'wowsims:master' into master

fb1ada6

Merge branch 'wowsims:master' into master

5fb6473

Merge branch 'wowsims:master' into master

eeec9ce

Adding monk as healer spec in the front end

78e9266

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

72d980a

Renewing mist (wip) + surging mist

6aa67fc

Merge branch 'wowsims:master' into master

d685e5e

Mistweaver changes

80b9f3e

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

2687aab

Merge branch 'wowsims:master' into master

ce9108c

Working on making monk spells functional

2bdec85

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

668dd2a

Merge branch 'wowsims:master' into master

bf11a9e

Merge branch 'wowsims:master' into master

26cca5c

Added cast while channeling logic

590b2ab

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

93a5f01

Merge branch 'wowsims:master' into master

aaf950e

Merge branch 'wowsims:master' into master

2cdfa93

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

7c773ef

Merge branch 'wowsims:master' into master

ea67b07

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

8e59baa

Merge branch 'wowsims:master' into master

42ca540

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

22ba653

Merge branch 'wowsims:master' into master

0f986db

Soothing mist fix + passives

b173c2d

Merge branch 'master' of https://github.com/Patrick-Hogeveen/mop

ce8f36a

channel fix + monk core changes

bc16a63

Merge branch 'wowsims:master' into master

10f82a9

github-actions bot added the Death Knight label Jun 30, 2025

Patrick-Hogeveen commented Jul 3, 2025

View reviewed changes

NerdEgghead requested changes Jul 4, 2025

View reviewed changes

Patrick-Hogeveen added 2 commits July 4, 2025 13:49

Soothing mist aura consolidation

258aa4c

Changes / fixes based on pr draft comments

b4dcd50

Mistweaver aura updates

eb1e58c

Patrick-Hogeveen closed this Jul 14, 2025

Patrick-Hogeveen reopened this Jul 14, 2025

Merge branch 'master' of github.com:wowsims/mop

ff438d4

github-actions bot added Death Knight Druid Hunter Mage Paladin Priest Rogue Shaman Warlock Warrior labels Jul 14, 2025

NerdEgghead requested changes Jul 15, 2025

View reviewed changes

1337LutZ reviewed Jul 18, 2025

View reviewed changes

1337LutZ reviewed Aug 11, 2025

View reviewed changes

sim/monk/mistweaver/passives.go

}

aura.Deactivate(sim)

},

})

Copy link

1337LutZ Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you should add the 1.5 .AttachSpellMod for the 2 BCK and TP

1337LutZ reviewed Aug 11, 2025

View reviewed changes

		//Checking for cast-while-channeling spells to allow the APL to not evaluate during channels unless absolutely necessary
		allowCastWhileChanneling bool

		baseHealing := 0 + spellCoeff*spell.HealingPower(target)
		spell.CalcAndDealHealing(sim, player, baseHealing, spell.OutcomeHealingCrit)

		ProcMask: core.ProcMaskSpellHealing,
		Flags: core.SpellFlagHelpful \| core.SpellFlagAPL, // \| core.SpellFlagCastWhileChanneling,

		ApplyEffects: func(sim core.Simulation, target core.Unit, spell *core.Spell) {
		//Currently target mistweaver only, will need to fix this

		chiGain := int32(1)
		mw.AddChi(sim, spell, chiGain, chiMetrics)

		if monk.MuscleMemoryAura.IsActive() {
		result.Damage += result.Damage * 1.5

Mistweaver implementation #380

Are you sure you want to change the base?

Mistweaver implementation #380

Uh oh!

Conversation

Patrick-Hogeveen commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NerdEgghead left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NerdEgghead commented Jul 12, 2025

Uh oh!

Patrick-Hogeveen commented Jul 14, 2025

Uh oh!

NerdEgghead left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1337LutZ Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1337LutZ Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1337LutZ Jul 18, 2025 •

edited

Loading

1337LutZ Aug 11, 2025 •

edited

Loading

1337LutZ Aug 11, 2025 •

edited

Loading