Mistweaver implementation #380
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| package mistweaver | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/wowsims/mop/sim/core" | ||
| "github.com/wowsims/mop/sim/monk" | ||
| ) | ||
|
|
||
| func (mw *MistweaverMonk) registerEnvelopingMist() { | ||
| actionID := core.ActionID{SpellID: 124682} | ||
| chiMetrics := mw.NewChiMetrics(actionID) | ||
| spellCoeff := 0.45 | ||
|
|
||
| mw.envelopingMist = mw.RegisterSpell(core.SpellConfig{ | ||
| ActionID: actionID, | ||
| SpellSchool: core.SpellSchoolNature, | ||
| ProcMask: core.ProcMaskSpellHealing, | ||
| Flags: core.SpellFlagHelpful | core.SpellFlagAPL, // | core.SpellFlagCastWhileChanneling, | ||
|
Comment on lines
+19
to
+20
There was a problem hiding this comment. Did you intend to comment out the extra flag here? |
||
| ClassSpellMask: monk.MonkSpellEnvelopingMist, | ||
|
|
||
| ManaCost: core.ManaCostOptions{BaseCostPercent: 0}, | ||
|
Comment on lines
+22
to
+23
There was a problem hiding this comment. You can just omit this field if the cost is 0. |
||
| Cast: core.CastConfig{ | ||
| DefaultCast: core.Cast{ | ||
| GCD: core.GCDDefault, | ||
| CastTime: time.Millisecond * 2000, | ||
| }, | ||
| }, | ||
| DamageMultiplier: 1, | ||
| ThreatMultiplier: 1, | ||
| CritMultiplier: mw.DefaultCritMultiplier(), | ||
|
|
||
| ExtraCastCondition: func(_ *core.Simulation, _ *core.Unit) bool { | ||
| return mw.GetChi() >= 3 | ||
| }, | ||
|
|
||
| ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) { | ||
|
|
||
| mw.SpendChi(sim, 3, chiMetrics) | ||
| spell.RelatedDotSpell.Cast(sim, target) | ||
|
|
||
| }, | ||
| }) | ||
|
|
||
| mw.envelopingMist.RelatedDotSpell = mw.RegisterSpell(core.SpellConfig{ | ||
| ActionID: actionID, | ||
| SpellSchool: core.SpellSchoolNature, | ||
| ProcMask: core.ProcMaskSpellHealing, | ||
| Flags: core.SpellFlagHelpful, | ||
| //ClassSpellMask: monk.MonkSpellEnvelopingMist, | ||
|
|
||
|
Comment on lines
+51
to
+52
There was a problem hiding this comment. Did you intend to comment out the spell mask here? |
||
| DamageMultiplier: 1, | ||
| ThreatMultiplier: 1, | ||
| CritMultiplier: mw.DefaultCritMultiplier(), | ||
| Hot: core.DotConfig{ | ||
| Aura: core.Aura{ | ||
| Label: "Enveloping Mist", | ||
| }, | ||
| NumberOfTicks: 6, | ||
| TickLength: 1 * time.Second, | ||
| AffectedByCastSpeed: true, | ||
| HasteReducesDuration: true, | ||
| OnSnapshot: func(sim *core.Simulation, target *core.Unit, dot *core.Dot, _ bool) { | ||
| dot.SnapshotBaseDamage = 0 + mw.CalcScalingSpellDmg(spellCoeff) | ||
| dot.SnapshotAttackerMultiplier = dot.Spell.CasterHealingMultiplier() | ||
| }, | ||
|
|
||
| OnTick: func(sim *core.Simulation, target *core.Unit, dot *core.Dot) { | ||
|
|
||
| dot.CalcAndDealPeriodicSnapshotHealing(sim, target, dot.OutcomeTick) | ||
|
|
||
| }, | ||
| }, | ||
|
|
||
| ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) { | ||
| hot := spell.Hot(target) | ||
| //Will probably have to remove enemy units as options for friendly spells? | ||
| if target.Type == core.EnemyUnit { | ||
| fmt.Printf("Attemping to cast Enveloping mist on enemy: %v\n", target.Label) | ||
| return | ||
| } | ||
|
Comment on lines
+79
to
+82
There was a problem hiding this comment. I think it would be better to |
||
|
|
||
| hot.Apply(sim) | ||
|
|
||
| }, | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| package mistweaver | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "github.com/wowsims/mop/sim/core" | ||
| "github.com/wowsims/mop/sim/core/stats" | ||
| "github.com/wowsims/mop/sim/monk" | ||
| ) | ||
|
|
||
| func (mw *MistweaverMonk) registerManaTea() { | ||
|
|
||
| buffActionID := core.ActionID{SpellID: 115294} | ||
| stackActionID := core.ActionID{SpellID: 123766} | ||
| manaMetrics := mw.NewManaMetrics(buffActionID) | ||
| manaPerTick := 0.0 | ||
| //numerOFTicks := 6 | ||
|
|
||
| mw.Monk.RegisterOnChiSpent(func(sim *core.Simulation, chiSpent int32) { | ||
|
|
||
| accumulatedChi := mw.outstandingChi + chiSpent | ||
|
|
||
| for accumulatedChi >= 4 { | ||
|
|
||
| mw.AddBrewStacks(sim, 1) | ||
| accumulatedChi -= 4 | ||
| } | ||
|
|
||
| mw.outstandingChi = accumulatedChi | ||
|
|
||
| }) | ||
|
|
||
| mw.ManaTeaStackAura = mw.RegisterAura(core.Aura{ | ||
| Label: "Mana Tea Stacks" + mw.Label, | ||
| ActionID: stackActionID, | ||
| Duration: time.Hour, | ||
| MaxStacks: 20, | ||
| }) | ||
|
|
||
| mw.Monk.RegisterOnNewBrewStacks(func(sim *core.Simulation, stacksToAdd int32) { | ||
|
There was a problem hiding this comment.
|
||
| mw.ManaTeaStackAura.Activate(sim) | ||
|
|
||
| procChance := mw.GetStat(stats.SpellCritPercent) | ||
|
|
||
| if sim.Proc(procChance/100, "Mana Tea") { | ||
| stacksToAdd += 1 | ||
| } | ||
|
|
||
| mw.ManaTeaStackAura.SetStacks(sim, mw.ManaTeaStackAura.GetStacks()+stacksToAdd) | ||
| }) | ||
|
|
||
| mw.RegisterSpell(core.SpellConfig{ | ||
| ActionID: buffActionID, | ||
| Flags: core.SpellFlagAPL | core.SpellFlagNoOnCastComplete | core.SpellFlagHelpful | core.SpellFlagChanneled, | ||
| ClassSpellMask: monk.MonkSpellManaTea, | ||
|
|
||
| Cast: core.CastConfig{ | ||
| DefaultCast: core.Cast{ | ||
| GCD: time.Millisecond * 1000, | ||
| }, | ||
| }, | ||
|
|
||
| Hot: core.DotConfig{ | ||
| SelfOnly: true, | ||
| Aura: core.Aura{ | ||
| Label: "Mana Tea", | ||
| Duration: 3 * time.Second, //Set at activation | ||
| }, | ||
| NumberOfTicks: 6, | ||
| TickLength: 500 * time.Millisecond, | ||
| AffectedByCastSpeed: false, //? | ||
| OnSnapshot: func(sim *core.Simulation, target *core.Unit, dot *core.Dot, isRollover bool) { | ||
| mw.manaTeaAura = dot.Aura | ||
| }, | ||
|
Comment on lines
+71
to
+73
There was a problem hiding this comment. General comment for readability: replace any unused function inputs (in this case |
||
| OnTick: func(sim *core.Simulation, target *core.Unit, spell *core.Dot) { | ||
| mw.AddMana(sim, manaPerTick, manaMetrics) | ||
|
|
||
| mw.ManaTeaStackAura.RemoveStack(sim) | ||
|
|
||
| }, | ||
| }, | ||
|
|
||
| ExtraCastCondition: func(sim *core.Simulation, target *core.Unit) bool { | ||
|
|
||
| return mw.ManaTeaStackAura.GetStacks() > 0 | ||
| }, | ||
|
|
||
| ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) { | ||
| manaPerTick = mw.MaxMana() * 0.05 //Patched to restore 5% instead of original 4% | ||
|
|
||
| hot := spell.SelfHot() | ||
| stacksToUse := min(mw.ManaTeaStackAura.GetStacks(), 6.0) | ||
| hot.Duration = time.Duration(stacksToUse) * 500 * time.Millisecond | ||
| hot.BaseTickCount = stacksToUse | ||
| hot.Activate(sim) | ||
| //mw.ManaTeaStackAura.SetStacks(sim, mw.ManaTeaStackAura.GetStacks()-1) | ||
|
|
||
| //spell.SelfHot().Apply(sim) | ||
|
|
||
| }, | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.