Remove ayon-usd related plugin.

[MustafaJafar]

Changelog Description

Remove CollectUSDPinningEnvVars plugin.

Additional Info

This is tested with ynput/ayon-usd#93
This is part of solution for ynput/ayon-usd#92

Testing notes:

1. everything should work as before.

[MustafaJafar]

This PR is made to reflect the changes I'm doing on my side when testing USD publish plugins.

[kalisp]

If I understand it correctly this moves collect_usd_pinning_env_vars.py‎ to ayon-usd, correct? What will happen if the plugin will stay here and be also in ayon-usd? (Or wont be there.)
The point is if there should be some dependency (and therefore one of the PRs should wait for release of the other one).
(As if we remove plugin from here AND customer will not update ayon-usd, environments will be missing.)

Actually, are these environment necessary for ayon-usd or are they necessary only farm (in that case they should probably stay here. As there are other DCC based plugins, which are in ayon-deadline as they make sense only there. If you dont have Deadline you dont need them in your DCC.

[MustafaJafar]

If I understand it correctly this moves collect_usd_pinning_env_vars.py‎ to ayon-usd, correct?

yes.

What will happen if the plugin will stay here and be also in ayon-usd? (Or wont be there.) The point is if there should be some dependency (and therefore one of the PRs should wait for release of the other one). (As if we remove plugin from here AND customer will not update ayon-usd, environments will be missing.)

This plugin is related to pinning feature in our USD Resolver. It updates the job submission vars.
tbh, it doesn't work as expected and it requires fixes in the usd addon and the resolver itself. we can also argue this plugin can be removed without adding any dependency as it doesn't just work.

Actually, are these environment necessary for ayon-usd or are they necessary only farm (in that case they should probably stay here. As there are other DCC based plugins, which are in ayon-deadline as they make sense only there. If you dont have Deadline you dont need them in your DCC.

Tbh, I'm not sure about the best approach here. I was doing some fixes and I recall the todo in this plugin was mentioned couple of times. so I included it among those fixes.

Tagging @BigRoy @antirotor for further info.

[MustafaJafar]

After some brainstorming and testing ynput/ayon-usd#93 I think we no longer need CollectUSDPinningEnvVars collector. Actually, I removed it from the linked PR as well.

[BigRoy]

@MustafaJafar can you elaborate on why you think it may not be needed anymore?

Without these vars set on the job:

{
        "PINNING_FILE_PATH": usd_pinning_rootless_file_path,
        "ENABLE_STATIC_GLOBAL_CACHE": "1",
}

What would be setting the pinning file for the Deadline job then?

Or did you just mean that you moved that logic, e.g. here?

[MustafaJafar]

What would be setting the pinning file for the Deadline job then?

Or did you just mean that you moved that logic, e.g. here?

yes, I've moved that logic to the extractor. there are also further info mentioned in ynput/ayon-usd#93 (comment)

[BigRoy]

Changes seem fine if ayon-usd logic will be taking this over.
I'm not sure if this needs an ayon_compatible requirement to ayon-usd to ensure it's only valid with an ayon usd version that has the logic added.

Yet at the same time, I've heard a few times "this is broken" anyway so I'm not sure how strongly we should hold to this for backwards compatibility. I'll leave that up to @MustafaJafar and @antirotor to decide since I think you've been discussing this mostly. I'm fine either way as long as we don't cut off anyone on this feature for a long time.

[MustafaJafar]

I don't have a strong opinion tbh.
But as said it's broken anyway. So, I'd vote for silently skipping adding a compatibility.

[iLLiCiTiT]

Looking at get_usd_pinning_envs it really doesn't make sense to have it here.