-
Notifications
You must be signed in to change notification settings - Fork 3
Clean up usd publish plugins #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up usd publish plugins #93
Conversation
|
This PR is made to reflect the changes I'm doing on my side when testing USD publish plugins. |
|
Tagging @philippe-ynput and @tadeas-hejnic for visibility. |
|
I've found out that collect_usd_pinning_env_vars.py plugin return nothing and the actual path is generated from
|
|
@antirotor The Current state of this PR should be working in Houdini. One thing is the pinning file workflow: Currently, Another thing, generalize the solution to work in Houdini and Maya. What Pinning File workflow should be:
What is currently happening:
|
|
@antirotor I've updated the todo above and I'd appreciate your help as I'm not sure how to fix get_usd_pinning_envs and the pinning file publishing. @tadeas-hejnic Could you please check the todo above? It may overlap with your PR #100 . This PR is dedicated for fixing another part of the issue so it shouldn't overlap as it's complementary to yours. |
Based on the TODOs it is not overlapping my PR. #100 is related just to the pinning file generation. |
|
It's weird that supporting staging directory in Houdini made pinning file publishing work as expected in develop branch |
client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py
Outdated
Show resolved
Hide resolved
|
Note for me, pinning file extraction removes it as cleaning up via |
|
So, me and @BigRoy agreed to
|
|
I tried opening a Houdini CMD with pinning env set and checking the Also, tagging @tadeas-hejnic in case if this is useful. But anyways, this is not related to the PR where the main focus here to fix some issue in publish plugins and make the resolver run on farm. |
|
I think this PR should work. gave it some test runs. |
client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py
Outdated
Show resolved
Hide resolved
client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py
Outdated
Show resolved
Hide resolved
client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py
Outdated
Show resolved
Hide resolved
|
TL;DR; This PR
Tagging @BigRoy @antirotor @philippe-ynput @tadeas-hejnic for visibility. |
client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py
Outdated
Show resolved
Hide resolved
client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py
Outdated
Show resolved
Hide resolved
client/ayon_usd/plugins/publish/extract_skeleton_pinning_json.py
Outdated
Show resolved
Hide resolved
BigRoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside of a few cosmetic notes - this looks good to me.
I wish if I were able to give it a nice test run with the new resolver. but let's merge it anyways. |


Changelog Description
ayon-usdrelated plugin. ayon-deadline#197.PINNING_FILE_PATHandENABLE_STATIC_GLOBAL_CACHEon publish JobAdditional Information
This doesn't fully solve the farm rendering issue #91 as
Testing notes:
Enable
With pinning disabled (live mode):
With pinning enabled:
__render__pin.jsonnext to__render__.usd.Resolve #92