Fix vapid key to_pem #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@zaru Can you please merge this important bug fix? We have been using our branch for almost 2 years in production, so it's safe to merge. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to upstream changes in the OpenSSL library, Ruby 2.6.7, 2.7 and all later versions break the method
VapidKey#to_pemof this library.You can read more here:
ruby/openssl#437
Without this fix, in the new Ruby versions, the
to_pemmethod would return the private key two times instead of the key pair (private key + public key).Please merge this fix as soon as possible. Thank you!