Skip to content

Conversation

@Cristib05
Copy link
Contributor

@Cristib05 Cristib05 commented Oct 29, 2025

This commit adds the possibility to check for a multicast route on a given interface
Related to #98290, #98290 (comment)

}

ARRAY_FOR_EACH(route->ifaces, i) {
if (!route->ifaces[i] || route->ifaces[i] != iface) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misra

Suggested change
if (!route->ifaces[i] || route->ifaces[i] != iface) {
if (route->ifaces[i] == NULL || route->ifaces[i] != iface) {

@Cristib05 Cristib05 force-pushed the route_lookup_by_iface branch from 2491078 to 3af27b2 Compare October 29, 2025 09:46
rlubos
rlubos previously approved these changes Oct 29, 2025
Copy link
Contributor

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some tests?

@Cristib05
Copy link
Contributor Author

Missing some tests?

added test case for this new added function

@Cristib05 Cristib05 requested review from pdgendt and rlubos October 29, 2025 12:42
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 29, 2025
@zephyrbot zephyrbot requested a review from nashif October 29, 2025 12:43
@Cristib05
Copy link
Contributor Author

How could my new added test case affect arch.arm.user.stack? I must admit I really don't understand this one.

@rlubos
Copy link
Contributor

rlubos commented Oct 29, 2025

How could my new added test case affect arch.arm.user.stack? I must admit I really don't understand this one.

It didn't, it's just some regression that slipped into main: #98494. Will need to wait for a hotfix

This commit adds the possibility to check for a multicast route on a
given interface

Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Adding test case to validate new added function,
`net_route_mcast_lookup_by_iface`

Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
@Cristib05 Cristib05 force-pushed the route_lookup_by_iface branch from 254d0da to 40aa6a2 Compare October 30, 2025 05:49
@Cristib05
Copy link
Contributor Author

Rebased.

@sonarqubecloud
Copy link

@jhedberg
Copy link
Member

Should this have a 4.4 milestone?

@cfriedt cfriedt merged commit 72d8814 into zephyrproject-rtos:main Nov 1, 2025
27 checks passed
Cristib05 added a commit to nxp-upstream/zephyr that referenced this pull request Nov 4, 2025
This commit makes use of zephyrproject-rtos#98464 and deletes a multicast route by
specified interface.

Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Cristib05 added a commit to nxp-upstream/zephyr that referenced this pull request Nov 4, 2025
This commit makes use of zephyrproject-rtos#98464 and deletes a multicast route by
specified interface.

Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Cristib05 added a commit to nxp-upstream/zephyr that referenced this pull request Nov 4, 2025
This commit makes use of zephyrproject-rtos#98464 and deletes a multicast route by
specified interface.

Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
@Cristib05 Cristib05 deleted the route_lookup_by_iface branch November 7, 2025 11:30
jhedberg pushed a commit that referenced this pull request Nov 13, 2025
This commit makes use of #98464 and deletes a multicast route by
specified interface.

Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Networking area: Tests Issues related to a particular existing or missing test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants