Skip to content

driver: gpio: pca_series: fix pca6416 driver issue #98475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

driver: gpio: pca_series: fix pca6416 driver issue #98475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions drivers/gpio/gpio_pca_series.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,9 @@ static inline int gpio_pca_series_reg_cache_read(const struct device *dev,
* @return int 0 if success
* -EINVAL if invalid arguments
* -EACCES if register is uncacheable
*
* @note the buffer must be little-endian, the same as I2C register layout,
* regardless of host machine endianness.
*/
static inline int gpio_pca_series_reg_cache_update(const struct device *dev,
enum gpio_pca_series_reg_type reg_type,
Expand Down Expand Up @@ -1664,23 +1667,12 @@ static void gpio_pca_series_interrupt_handler_standard(const struct device *dev,
int_fall = gpio_pca_series_reg_cache_mini_get(dev)->int_fall;
#endif /* CONFIG_GPIO_PCA_SERIES_CACHE_ALL */

/** check if any interrupt enabled */
if ((!int_rise) && (!int_fall)) {
goto out;
}

/** read current input value, and clear status if reg is present */
ret = gpio_pca_series_reg_read(dev, PCA_REG_TYPE_1B_INPUT_PORT, (uint8_t *)&input);
if (ret) {
goto out;
}
input = sys_le32_to_cpu(input);
/** compare input to input_old to get transitioned_pins */
transitioned_pins = input_old ^ input;

/** Mask gpio transactions with rising/falling edge interrupt config */
int_status = (int_rise & transitioned_pins & input)
| (int_fall & transitioned_pins & (~input));

/** update current input to cache */
#ifdef CONFIG_GPIO_PCA_SERIES_CACHE_ALL
Expand All @@ -1692,6 +1684,18 @@ static void gpio_pca_series_interrupt_handler_standard(const struct device *dev,
gpio_pca_series_reg_cache_mini_get(dev)->input_old = input;
#endif /* CONFIG_GPIO_PCA_SERIES_CACHE_ALL */

/** check if any interrupt enabled */
if ((!int_rise) && (!int_fall)) {
goto out;
}

/** compare input to input_old to get transitioned_pins */
transitioned_pins = input_old ^ input;

/** Mask gpio transactions with rising/falling edge interrupt config */
int_status = (int_rise & transitioned_pins & input)
| (int_fall & transitioned_pins & (~input));

out:
k_sem_give(&data->lock);

Expand Down Expand Up @@ -2253,12 +2257,12 @@ const struct gpio_pca_series_part_config gpio_pca_series_part_cfg_pca9555 = {
#define GPIO_PCA_PART_CFG_PCA_PART_NO_PCA6416 (&gpio_pca_series_part_cfg_pca6416)

const struct gpio_pca_series_part_config gpio_pca_series_part_cfg_pca6416 = {
.port_no = GPIO_PCA_PORT_NO_PCA_PART_NO_PCA6408,
.flags = GPIO_PCA_FLAG_PCA_PART_NO_PCA6408,
.port_no = GPIO_PCA_PORT_NO_PCA_PART_NO_PCA6416,
.flags = GPIO_PCA_FLAG_PCA_PART_NO_PCA6416,
.regs = gpio_pca_series_reg_pca9539,
#ifdef CONFIG_GPIO_PCA_SERIES_CACHE_ALL
# ifdef GPIO_NXP_PCA_SERIES_DEBUG
.cache_size = GPIO_PCA_GET_CACHE_SIZE_BY_PART_NO(PCA_PART_NO_PCA6408),
.cache_size = GPIO_PCA_GET_CACHE_SIZE_BY_PART_NO(PCA_PART_NO_PCA6416),
# endif /* GPIO_NXP_PCA_SERIES_DEBUG */
.cache_map = gpio_pca_series_cache_map_pca953x,
#endif /* CONFIG_GPIO_PCA_SERIES_CACHE_ALL */
Expand Down
Loading