This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Add core_test_utils crate and move core tests there#781
Open
GraDKh wants to merge 1 commit intodgordon/move_compute_test_utilsfrom
Open
Add core_test_utils crate and move core tests there#781GraDKh wants to merge 1 commit intodgordon/move_compute_test_utilsfrom
GraDKh wants to merge 1 commit intodgordon/move_compute_test_utilsfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2025
1d95047 to
85ef870
Compare
6b7c982 to
06dd05b
Compare
BenjaminTrapani
approved these changes
Jun 17, 2025
85ef870 to
2a5f336
Compare
06dd05b to
cc9e819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Move test utilities from compute to core
TL;DR
Created a new
binius_core_test_utilscrate and moved test utilities related to core functionality frombinius_compute_test_utils.What changed?
crates/core/test_utilsdirectory with its own Cargo.tomlcompute/test_utilstocore/test_utils:bivariate_sumcheckpiopring_switchbinius_core_test_utilsas a dev-dependency incrates/core/Cargo.tomlHow to test?
Run the tests in the core crate to ensure they still pass with the new test utilities:
cargo test -p binius_coreWhy make this change?
This change improves the organization of test utilities by placing them closer to the code they're testing. Test utilities specific to core functionality now live in the core crate, making the codebase more modular and easier to maintain.