This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Introduce macros to instantiate compute layer test#782
Open
GraDKh wants to merge 1 commit intodgordon/add_core_test_utils_cratefrom
Open
Introduce macros to instantiate compute layer test#782GraDKh wants to merge 1 commit intodgordon/add_core_test_utils_cratefrom
GraDKh wants to merge 1 commit intodgordon/add_core_test_utils_cratefrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2025
e713605 to
f99161f
Compare
6b7c982 to
06dd05b
Compare
06dd05b to
cc9e819
Compare
f99161f to
ed8424c
Compare
onesk
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Introduce a macro to instantiate all compute layer tests with the given compute layer type.
What changed?
test_generic_multiple_multilinear_evaluationsandtest_generic_map_with_multilinear_evaluationsfunctions by properly handling device memory alignment requirementsinstantiate_compute_layer_tests!macro that generates all the standard compute layer tests for a given tower, HAL, and compute holder typecrates/compute/tests/layer.rsandcrates/fast_compute/tests/layer.rsto use the new macro, significantly reducing code duplicationHow to test?
Run the compute layer tests to verify they pass with the new alignment handling:
Why make this change?
The new macro eliminates significant code duplication across test files, making it easier to maintain and extend the test suite in the future.