This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Extract macro to instantiate ring switch tests#785
Open
GraDKh wants to merge 1 commit intodgordon/extract_bivariate_sumcheck_macrofrom
Open
Extract macro to instantiate ring switch tests#785GraDKh wants to merge 1 commit intodgordon/extract_bivariate_sumcheck_macrofrom
GraDKh wants to merge 1 commit intodgordon/extract_bivariate_sumcheck_macrofrom
Conversation
This was referenced Jun 16, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
GraDKh
force-pushed
the
dgordon/extract_piop_tests_macro
branch
from
9bce9dc to
638ebea
Compare
GraDKh
force-pushed
the
dgordon/extract_bivariate_sumcheck_macro
branch
2 times, most recently
from
6fdf946 to
d40060a
Compare
GraDKh
force-pushed
the
dgordon/extract_piop_tests_macro
branch
from
638ebea to
239e7d5
Compare
djadjka
reviewed
Jun 17, 2025
djadjka
approved these changes
Jun 17, 2025
Contributor
djadjka
left a comment
djadjka
left a comment
There was a problem hiding this comment.
LGTM, just question to $compute_layer
GraDKh
force-pushed
the
dgordon/extract_piop_tests_macro
branch
from
239e7d5 to
baf542a
Compare
GraDKh
force-pushed
the
dgordon/extract_bivariate_sumcheck_macro
branch
2 times, most recently
from
2d9c88d to
f2aa965
Compare
GraDKh
force-pushed
the
dgordon/extract_piop_tests_macro
branch
from
baf542a to
6c73e0a
Compare
GraDKh
force-pushed
the
dgordon/extract_piop_tests_macro
branch
from
6c73e0a to
4c96807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a macro to instantiate PIOP and ring switch tests for different compute layers.
What changed?
instantiate_piop_tests!macro inpiop.rsthat generates six test cases for different PIOP scenariosinstantiate_ring_switch_tests!macro inring_switch.rsthat generates two test cases for ring switch functionalityring_switch.rsHow to test?
Run the tests with:
cargo test --package binius-coreThe tests will now run for both CPU and FastCPU compute layers, verifying that the PIOP and ring switch functionality works correctly across different implementations.
Why make this change?
This change improves test coverage by ensuring that PIOP and ring switch functionality works consistently across different compute layer implementations. By using macros to generate the tests, we avoid code duplication while still testing the same functionality with different backends. This makes it easier to add support for new compute layers in the future, as they can simply instantiate these test macros to verify compatibility.