Skip to content

Conversation

@hijimasa
Copy link

[add] check velocity command exists to publish command
Solved the problem of commands not being published even if velocity was given, since only the difference in position was checked.

[change] separate position/velocity/effort command
This is the form of command expected by Isaac Sim.
Reference: https://docs.omniverse.nvidia.com/isaacsim/latest/ros2_tutorials/tutorial_ros2_manipulation.html#position-and-velocity-control-modes

[change] use mimic joint name to publish command
When the commands were separated, the joint state index was no longer available, so it was changed to search by name.

Edit: fixed bug about mimic joint only publish position command

@JafarAbdi JafarAbdi self-assigned this Sep 5, 2024
/// The size of this vector is (standard_interfaces_.size() x nr_joints)
std::vector<std::vector<double>> joint_commands_;
std::vector<std::vector<double>> joint_states_;
std::vector<std::vector<double>> initial_joint_commands_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used to store the initial value of each joint; assigning to joint_commands_ will overwrite the value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using Isaac Sim and Move It 2, I have a different variable for joint_command because of the overwriting behavior when I set the initial value to joint_command. It seems that joint_command is overwritten with all zeros even when joint_command messages are not exchanged.

… with robot starting state"

This reverts commit 2b23e6c.
@JafarAbdi
Copy link
Contributor

I added initial integration test to the repo #28, do you mind helping me writing tests for this PR as well? Writing tests that would fail without this PR

@hijimasa
Copy link
Author

hijimasa commented Oct 9, 2024

@JafarAbdi Do I just merge feature/integration_test and add the test?

@JafarAbdi
Copy link
Contributor

@JafarAbdi Do I just merge feature/integration_test and add the test?

What do you think about creating a new branch on top of feature/integration_test then add them there?

@JafarAbdi
Copy link
Contributor

This is part of #29

@JafarAbdi JafarAbdi closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants