-
Notifications
You must be signed in to change notification settings - Fork 16
Convert function unit tests #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
def4c79 to
73c2971
Compare
saga-dasgupta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you haven't removed the rust unit tests.
saga-dasgupta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and verified that all the unit tests have been replaced by fixtures and all the fixtures pass for cart validation, cart transform, delivery customization, discount and discount allocator functions for both Rust and JS.
achitojha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified all extension tests succeed and use the respective json files for Rust & Javascript versions of "Fulfillment constraint" / "Local pickup delivery option generator" / "Pickup point delivery option generator" / "Payment customization"
Background
Fixes https://github.com/shop/issues-shopifyvm/issues/765
Converts existing unit tests to integration tests instead.
Also covers the rust side of https://github.com/shop/issues-shopifyvm/issues/755
Solution
Create a fixture representing each of the existing unit test scenarios.
Tophat
Run the generate command targetting this branch
Checklist