-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
bevy_material #22426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
bevy_material #22426
Conversation
…e, bind_group_layout_entries
|
@atlv24 is this ready for review? You've added the label but it's still in draft mode :) |
|
the label is "Needs Review" not "Ready for Review" :P It is reviewable, but i recommend reviewing and letting char's PR merge first. |
Love how simple this is! |
|
Yeah im pretty happy with the diff being 1,227 additions and 607 deletions, and the majority of the additions are license files and the new tomls |
|
I really appreciate all the exploratory work you did in this space btw @Zeophlite ! It was very useful for determining where we needed another "cut" so to speak to make the crate fall out more cleanly. |
Objective
MaterialPropertiesfrombevy_pbrtobevy_material#21543 on top of More fully type erase all pbr types from specialization #22408, you can view a clean diff here: https://github.com/tychedelia/bevy/compare/type-erase-more-materials...atlv24:ad/material2?expand=1Solution
Testing