Skip to content

[Merged by Bors] - ci: Update the workflow so the chain doesn’t get skipped when upload_cache is skipped#35389

Closed
marcelolynch wants to merge 2 commits intoleanprover-community:masterfrom
marcelolynch:2026/02/FixPostStepSkip
Closed

[Merged by Bors] - ci: Update the workflow so the chain doesn’t get skipped when upload_cache is skipped#35389
marcelolynch wants to merge 2 commits intoleanprover-community:masterfrom
marcelolynch:2026/02/FixPostStepSkip

Conversation

@marcelolynch
Copy link
Contributor

@marcelolynch marcelolynch commented Feb 16, 2026

Currently some PRs sent to bors have ended up failing (#35330, #34667) because the upload_cache step was skipped, causing the required Post-Build and Post-CI jobs to get skipped as well. This PR adjusts the conditionals to ensure that those steps still run even if the cache upload gets skipped.

@github-actions
Copy link

github-actions bot commented Feb 16, 2026

PR summary 3bbc5c706c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Feb 16, 2026
@bryangingechen
Copy link
Contributor

bors try

mathlib-bors bot pushed a commit that referenced this pull request Feb 16, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 16, 2026

try

Build failed:

Updated post-CI job condition to ensure it runs only if direct dependencies succeeded.
@bryangingechen
Copy link
Contributor

bors try

mathlib-bors bot pushed a commit that referenced this pull request Feb 16, 2026
…cache is skipped (#35389)

Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 16, 2026

@bryangingechen
Copy link
Contributor

Requesting review from @adomani and @kim-em since I added a fix to this.

@adomani
Copy link
Contributor

adomani commented Feb 16, 2026

Thanks: let's get this moving!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 16, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 16, 2026
…cache is skipped (#35389)

Currently some PRs sent to `bors` have ended up failing (#35330, #34667) because the upload_cache step was skipped, causing the required Post-Build and Post-CI jobs to get skipped as well. This PR adjusts the conditionals to ensure that those steps still run even if the cache upload gets skipped.

Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title ci: Update the workflow so the chain doesn’t get skipped when upload_cache is skipped [Merged by Bors] - ci: Update the workflow so the chain doesn’t get skipped when upload_cache is skipped Feb 16, 2026
@mathlib-bors mathlib-bors bot closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants