-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Added common command to check direct use of dependencies, #PG-3272 #21969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…grep package not available
|
Generally I'm happy with this, any notes/concerns from @matomo-org/core-reviewers? |
|
Also, should this be mentioned in the changelog? I'm 50/50 on that. |
@michalkleiner We added in TestRunner as we don't need a release for it, so I don't think we would need to mention it in changelog, if we do might be useful for other plugin developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just a minor comment on the paramter descriptions 👍 Not sure that we need to mention the new command in the changelog as long as the developer documentation is updated.
@bx80 Created matomo-org/developer-documentation#778 to mention the same in developer documentation. Can we merge this PR now ? |
|
Thanks for opening the docs PR as well, @AltamashShaikh. |
Description:
Added common command to check direct use of dependencies
Fixes: #PG-3272
Review