feat: native SQLite backend via napi-rs with KV channel protocol#4496
feat: native SQLite backend via napi-rs with KV channel protocol#4496NathanFlurry merged 1 commit intomainfrom
Conversation
|
🚅 Deployed to the rivet-pr-4496 environment in rivet-frontend
|
053feea to
3525a83
Compare
3525a83 to
5e48bbb
Compare
5e48bbb to
b9dd7c7
Compare
PR Review: Native SQLite Backend via napi-rs with KV Channel ProtocolThis is a substantial feature (~14.6k additions across 96 files) introducing a native SQLite backend that routes page-level I/O over a new WebSocket KV channel protocol. The architecture is well-designed overall. Architecture AssessmentThe design choices are sound:
Issues1. Breaking Metric Renames Without Documentation
These are silent breaking changes for any existing dashboards or alerts. There is no migration note, no changelog entry, and no update to dashboard definitions in the repo. Existing Grafana dashboards or alert rules referencing these metric names will silently stop working after deployment. 2. Committed Binary Artifact
Native addon binaries should be built in CI and distributed via npm platform packages (the 3. Fragile
|
b9dd7c7 to
053d289
Compare
053d289 to
bf306e1
Compare
bf306e1 to
2252912
Compare
2252912 to
e325de0
Compare
e325de0 to
db4e9a3
Compare
db4e9a3 to
78bdfd2
Compare
78bdfd2 to
f6a75a6
Compare
f6a75a6 to
866069d
Compare
866069d to
64510be
Compare
64510be to
22fdbd8
Compare
22fdbd8 to
027d71c
Compare
Merge activity
|
027d71c to
7f81e1b
Compare

No description provided.