Conversation
|
🚅 Deployed to the rivet-pr-4551 environment in rivet-frontend
|
PR Review: fix: optimize e2e actor pathSummaryThis PR reduces end-to-end actor path latency through namespace operation caching, reqwest client pre-warming, tracing improvements, an envoy client shutdown race fix, and new Sleep/Reallocate actor signals. Potential Bugs1. Debug /foo endpoint left in test-envoy 2. Race condition: abort handler fires before envoy is assigned 3. LOG_TIMESTAMP default flip is a silent behavioral change Code Quality4. TODO without issue reference in sleep signal handler 5. Main::Reallocate silent drop while Reallocating 6. Leftover console.log in test script PerformanceNamespace caching (good): Both namespace_get_local and namespace_resolve_for_name_local are now cached via fetch_all_json/fetch_one_json. Cache misses when namespace is not found correctly avoid polluting the cache with negative results. Reqwest pre-warming (good): Eagerly initializing clients in Pools::create() matches the CLAUDE.md guidance to reuse rivet_pools::reqwest::client(). Minor7. RUST_LOG=warn removal from engine-rocksdb-release.sh 8. pnpm-lock.yaml specifier mismatch for @types/bun Convention Checks (CLAUDE.md)
Overall this is a solid performance improvement. Main items to address before merge: remove the /foo debug endpoint, clean up the console.log timestamp artifacts, and confirm the RUST_LOG removal is intentional. The sleep/reallocate signal edge cases and abort handler race are worth tracking issues even if not merge-blocking. |
Merge activity
|
f52ab07 to
b453037
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: