Conversation
|
🚅 Deployed to the rivet-pr-4534 environment in rivet-frontend
|
PR Review: feat: basic envoy tunnel implGood foundational work on the HTTP tunnel implementation. There are a few bugs and design concerns worth addressing before merging. Bugs1. Wrong field name for max payload check (
2. Map lookup by array key always fails ( // This pattern breaks -- Map uses reference equality for object keys
pendingRequests: new Map<[protocol.GatewayId, protocol.RequestId], PendingRequest>()
3.
4. Streaming request body: initial body bytes are discarded ( In the streaming path of 5. SIGTERM/SIGINT copy-paste bug ( Both Design Concerns6.
7. Errors from The 8. Oversized body throws instead of returning an error response (
9. Per CLAUDE.md: "Never modify an existing published Minor
|
056dbbc to
ecb7a20
Compare
748e9f1 to
9adad6e
Compare
ecb7a20 to
58851a4
Compare
9adad6e to
14e5bc7
Compare
14e5bc7 to
d705065
Compare
58851a4 to
68bbabd
Compare
68bbabd to
5c9a464
Compare
d705065 to
da489fa
Compare
Merge activity
|
da489fa to
539544e
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: