Skip to content

Update documentation for Zenoh timestamping configuration#889

Open
jordanburklund wants to merge 1 commit intoros2:rollingfrom
jordanburklund:fix/zenoh_timestamping_doc
Open

Update documentation for Zenoh timestamping configuration#889
jordanburklund wants to merge 1 commit intoros2:rollingfrom
jordanburklund:fix/zenoh_timestamping_doc

Conversation

@jordanburklund
Copy link
Contributor

Description

Update documentation for Zenoh timstamping configurations for server and router configs. When testing locally with a simple "transient local" publisher and subscriber, the comment in the default configurations seems to be outdated. "transient local" topics were still working even when setting timestamping: { enabled: false } for both sending topics locally on the same machine and sending topics between two different machines over the network.

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

/// Whether data messages should be timestamped if not already.
/// Accepts a single boolean value or different values for router, peer and client.
///
/// ROS setting: PublicationCache which is required for transient_local durability
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what to replace this with, so I left it as a WIP and will update it based on feedback from the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants