Skip to content

Document Light contact shadows often looking broken #35316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2022
Merged

Document Light contact shadows often looking broken #35316

merged 1 commit into from
Feb 17, 2022

Conversation

@Calinou
Copy link
Member

@Calinou Calinou commented Jan 19, 2020 •
edited
Loading

Time has showed yet again that people are often confused by this feature 🙂

@Calinou Calinou force-pushed the contact-shadows-hide-from-editor branch from 8efc450 to 278c721 Compare January 19, 2020 13:32
@Calinou Calinou mentioned this pull request Jan 26, 2020
Closed
@Calinou Calinou added this to the 4.0 milestone Mar 12, 2020
@Calinou
Copy link
Member Author

Calinou commented Apr 17, 2020 •
edited
Loading

Code related to contact shadows was removed in the master branch, as shadow normal offset bias and shadow pancaking are better (and faster) replacements. However, I still think this has value for the 3.x branch.

See also #43207.

@Calinou Calinou mentioned this pull request Aug 22, 2020
Closed
@Calinou Calinou changed the base branch from master to 3.2 October 19, 2020 14:47
@Calinou Calinou mentioned this pull request Oct 20, 2020
Open
@Calinou Calinou mentioned this pull request Dec 5, 2020
Closed
@Calinou Calinou mentioned this pull request Jan 13, 2021
Open
@Calinou Calinou requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@Calinou Calinou mentioned this pull request Jun 28, 2021
Closed
This was referenced Sep 28, 2021
Closed
Closed
@Calinou Calinou mentioned this pull request Oct 24, 2021
Merged
@Calinou Calinou force-pushed the contact-shadows-hide-from-editor branch from 278c721 to b6d4106 Compare October 24, 2021 15:14
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
@akien-mga akien-mga modified the milestones: 4.0, 3.5 Feb 10, 2022
@akien-mga
Copy link
Member

akien-mga commented Feb 10, 2022

As discussed in PR review meeting, we prefer not to hide the feature this way, but only document the known issues in its description.

@Calinou Calinou force-pushed the contact-shadows-hide-from-editor branch from b6d4106 to 9171737 Compare February 17, 2022 01:04
@Calinou Calinou requested a review from a team as a code owner February 17, 2022 01:04
@Calinou
Copy link
Member Author

Calinou commented Feb 17, 2022

As discussed in PR review meeting, we prefer not to hide the feature this way, but only document the known issues in its description.

I remade this PR to only change the documentation.

@Calinou Calinou changed the title Hide the contact shadow property as it often looks broken Document Light contact shadows often looking broken Feb 17, 2022
@akien-mga akien-mga merged commit 125e419 into godotengine:3.x Feb 17, 2022
@akien-mga
Copy link
Member

akien-mga commented Feb 17, 2022

Thanks!

@akien-mga
Copy link
Member

akien-mga commented Feb 17, 2022

Cherry-picked for 3.4.3.

@Calinou Calinou deleted the contact-shadows-hide-from-editor branch February 17, 2022 17:50
@Calinou Calinou mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

documentation enhancement

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@Calinou @akien-mga